Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parameter manager regional parameter datasource google_parameter_manager_regional_parameter #12640

Conversation

abheda-crest
Copy link
Contributor

@abheda-crest abheda-crest commented Dec 23, 2024

Add support for parameter manager regional parameter datasource google_parameter_manager_regional_parameter.

More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview

Note: This PR is dependent upon the parameter manager regional parameter resource which will be added as a part of the PR #12631

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_parameter_manager_regional_parameter` (beta)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 23, 2024
@abheda-crest abheda-crest marked this pull request as ready for review January 9, 2025 05:48
@github-actions github-actions bot requested a review from zli82016 January 9, 2025 05:48
Copy link

github-actions bot commented Jan 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@abheda-crest
Copy link
Contributor Author

I've attached screenshot for the local test run for the test cases for google_parameter_manager_regional_parameter datasource:

image

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 9, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 40 insertions(+))
google-beta provider: Diff ( 4 files changed, 140 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 5
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • parametermanagerregional

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceParameterManagerRegionalRegionalParameter_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceParameterManagerRegionalRegionalParameter_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit 9f506b9 into GoogleCloudPlatform:main Jan 9, 2025
14 checks passed
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 13, 2025
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 13, 2025
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants